[PATCH] Add --with-ext-lib-XXX support to SMB_EXT_LIB_FROM_PKGCONFIG

Jelmer Vernooij jelmer at samba.org
Sat Feb 21 17:23:13 GMT 2009


Hi Sam,

On Thu, 2009-02-05 at 22:41 +0100, Jelmer Vernooij wrote:
> I've indeed not pushed it yet, since I managed to get m4 to hang
> indefinitely with my current version of the patch on some systems. 
I've figured out what the problem was, and pushed the fixed version to
master. Sorry it took so long.

Cheers,

Jelmer

> On Thu, 2009-02-05 at 14:33 +0000, Sam Liddicott wrote:
> > Jelmer, I think you still didn't push this.
> > 
> > Sam
> > 
> > * Sam Liddicott wrote, On 10/12/08 10:21: 
> > > * Jelmer Vernooij wrote, On 26/11/08 20:46:
> > >   
> > > > On Wed, 2008-11-26 at 20:02 +0000, Sam Liddicott wrote:
> > > >   
> > > >     
> > > > > Jelmer Vernooij wrote: 
> > > > >     
> > > > >       
> > > > > > On Wed, Nov 26, 2008 at 06:19:30PM -0000, Sam Liddicott wrote:
> > > > > >   
> > > > > >       
> > > > > >         
> > > > > > > How about --enable-internal-libldb ?
> > > > > > >     
> > > > > > >         
> > > > > > >           
> > > > > > Yeah, that would make sense as well (perhaps more than
> > > > > > --enable-external, if auto is going to be the default). In the meantime, 
> > > > > > I incorporated my comments in your patch. The result is attached.
> > > > > >   
> > > > > >       
> > > > > >         
> > > > > I don't mind if you re-write half a days reading and work in only half
> > > > > an hour!
> > > > > Looks good to me...
> > > > >     
> > > > >       
> > > > I'm sorry, I didn't intend to redo your work :-( My patch was still
> > > > based on yours though. 
> > > >   
> > > >     
> > > np
> > >   
> > > > I'll push this into master.
> > > >   
> > > >     
> > > Have you pushed yet?
> > > 
> > > Sam
> > >   
> > 
-- 
Jelmer Vernooij <jelmer at samba.org> - http://samba.org/~jelmer/
Jabber: jelmer at jabber.fsfe.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 315 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20090221/d434990a/attachment.bin


More information about the samba-technical mailing list