[SCM] Samba Shared Repository - branch master
steven.danneman at isilon.com
Fri Feb 20 17:33:54 MST 2009
> On Thu, Feb 19, 2009 at 11:17:50AM +0100, Stefan (metze) Metzmacher
> > > commit c441f58dedc465f59060296815a0bc7f9aeb743f
> > > Author: todd stecher <todd.stecher at gmail.com>
> > > Date: Tue Feb 17 16:16:35 2009 -0800
> > >
> > > S3: Allow SMBD processes to survive in low memory condidtions
> > >
> > > This commit adds a configure argument which allows for setting
> > > in the madvise() API. With this enabled the kernel won't kill
> SMBD when
> > > it's running low on memory.
> > >
> > wouldn't it make sense to add this call to become_daemon() so that
> > nmbd and winbindd also get the protection.
> > I'm also wondering if we really want that the child (per connection)
> > smbds are also protected.
> Yep, I think at most the parent smbd should be protected if at all.
> We've had bad memleaks in the past and I'm sure in certain workloads
> still have them, and the kernel should be given a chance to kill the
> main culprit.
> Having all smbd's protected this way is definitely wrong.
Traditionally we protected all smbd daemons because we're a NAS product
and they're the more important system services :) But I agree it makes
more sense to let individual piggy connections die, but save the
I've incorporated both of your feedback in:
More information about the samba-technical