readdir conftest

Herb Lewis hlewis at panasas.com
Thu Feb 19 19:09:57 MST 2009


Jeremy Allison wrote:
> On Wed, Feb 18, 2009 at 11:56:21AM -0800, Herb Lewis wrote:
>> Currently in samba configure there is a test to see if readdir
>> is broken and then to see if it can be replaced by other calls
>> such as getdirentries. This tests assumes that a directory that
>> is opened will not do directory compaction while still open -
>> it uses seekdir to go to the location after deleted files. This
>> is not true of course for NFS mounted filesystems (or in our case
>> for panfs).
>>
>> Where in samba do we rely on this behavior?
> 
> It's for the old OS/2 and DOS deltree behavior.
> Not sure if any new clients will use this, but
> we have torture tests to ensure we don't regress.
> 
> What does directory compaction do to the ordering
> returned (just another good reason not to do NFS
> re-exports IMHO) ?
> 
> Jeremy.
I didn't see any reordering in the tests I was doing, just
the compaction, but the conftest was always just deleting
the first 4 entries. I'm not sure what would happen if the
deletes were "scattered".


More information about the samba-technical mailing list