S-1-22-X-Y sids

simo idra at samba.org
Thu Feb 12 12:56:07 MST 2009


On Thu, 2009-02-12 at 17:51 +0100, Stefan (metze) Metzmacher wrote:
> Hi,
> 
> I think we should only add S-1-22-X-Y sids to the nttoken
> in the create_local_token() function.
> 
> Currently we only add S-1-22-2-Y (unix group) sids when
> the auth_sam module is used.
> 
> Is it ok, to push this branch to master?
> http://gitweb.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/master3-fix
> 
> I could also backport the patches to v3-3-test and v3-2-test,
> but they don't apply in v3-0-test.
> 
> Comments please:-)

Is there any side effect (or bug get fixed) by this change ?
The comments and the code seem ok, but I had no time to carefully
analyze the code paths that would be affected.

Simo.

-- 
Simo Sorce
Samba Team GPL Compliance Officer <simo at samba.org>
Principal Software Engineer at Red Hat, Inc. <simo at redhat.com>



More information about the samba-technical mailing list