[PATCH] Stop ldb.h including private ldb_includes.h
simo.sorce at xsec.it
Tue Feb 10 07:25:45 MST 2009
On Tue, 2009-02-10 at 13:24 +0000, Sam Liddicott wrote:
> [I've Cc'd some of the earlier ldb authors]
> ldb_includes.h is a temporary file until the ldb build system
> is improved.
> This is a preliminary improvement to separating ldb from samba
> ldb_includes contains private includes required to build libldb
> and should not be included by public ldb header files.
> This patch has .c files which required ldb_includes.h to include
> it directly so that ldb_includes.h does not need to be installed
> with other ldb_header files.
> NOTE: ldb_private.h on the other hand is a public header file
> needed by externally build ldb modules.
> NOTE: this is a preliminary improvement.
> Probably -D_SAMBA_VERSION_=4 still needs defining so that the
> ldb tools can use samba auth (-P) and other samba4 enhancements,
> but ldb cannot yet be built seperately from samba4 in this manner.
Ok, after discussion and clarification on IRC I think we are on the
right track here, but the patch as is requires more work.
More information about the samba-technical