[PATCH][SAMBA4] 3 patches to get samba4 to build on OpenSolaris 08.11

[Torgeir Lerkerød]

Hi,

2009/2/9 Jelmer Vernooij <jelmer at samba.org>

> Hi,
>
> On Mon, 2009-02-09 at 21:30 +0100, Torgeir Lerkerød wrote:
> > Attached patches makes Samba4 build on OpenSolaris. OpenSolaris passes
> the
> > testsuite with 14 errors, many seems related to the same problem. I'll
> fix
> > that when I figure out whats wrong ;-) (BTW, there is something wrong
> with
> > NSS-Wrapper also had to add the wrapped group to /etc/group to get
> > provisioning working.)
> Thanks for working on fixing this.
>
> 0003-Fix-errornos-expectation-that-all-non-gcc-compilers.patch:
>  This is already using the AX_CFLAGS_IRIX_OPTION() flag, which should
>  do the right thing; I think this may need to be fixed to not do anything
> on Solaris instead.
>

Have you looked at the code in AX_CFLAGS_IRIX_OPTION. It expects the caller
to know that you have an IRIX cc. So you can of'course rework the howl
AX_CFLAGS_IRIX_OPTION, but a case check is much easier ;-) I am not going to
rework a howl file when a case switch is enough :-D


> 0002-Fix-include.patch:
>  This should ideally go into heimdal upstream, as the code is
>  imported from there.


Well it wouldn't have been a problem if samba 4's heimdal version wasn't
from aug 2008. There are other fixes like this in there done by metze. So
this needs to go in to build on Solaris until somebody do an upgrade of
heimdal... Of'course you can ignor Solaris as a platform, but if not....


>
> 0003-Fix-errornos-expectation-that-all-non-gcc-compilers.patch
>  Thanks, applied!
>

Thanks

Regards,
Torgeir