Fixing SMBC_getatr prototype

[Derrell Lipman]

On Thu, Feb 5, 2009 at 8:21 PM, Jeremy Allison <jra at samba.org> wrote:

> On Wed, Feb 04, 2009 at 08:38:28PM -0500, Derrell Lipman wrote:
> > On Wed, Feb 4, 2009 at 3:59 PM, Jeremy Allison <jra at samba.org> wrote:
> >
> > > Derrell,
> > >
> > >        Currently the prototype for SMBC_getatr
> > > takes a "char *" instead of a "const char *".
> > > I'd like to fix this. Will this break the current
> > > ABI for libsmbclient ?
> >
> >
> > Hi Jeremy,
> >
> > My convention is that any function with an uppercase module prefix
> (SMBC_)
> > is global only because it is referenced in other files internal to
> > libsmbclient. Public functions (except possibly some that remain for
> legacy
> > reasons, and I don't believe any of those remain) all use a lowercase
> module
> > prefix (smbc_). Therefore it will not break the ABI to change it. I have
> no
> > problem with that change as long as it doesn't add compiler warnings. :-)
> >
> > What led you to discover this?
>
> Actually, it was compiler warnings when compiling 3.3.x.
>

Jeremy, this is curious. I generally don't leave compiler warnings alone. I
just removed the only two compiler warnings I was getting in the v3-3-test
code, and they weren't to do with SMBC_getatr.

Derrell