[PATCH] Add infrastructure for gathering statistics on SMB messages

[Volker Lendecke]

Hi, Todd!

On Tue, Feb 03, 2009 at 05:32:00PM -0800, Todd Stecher wrote:
> Isilon has a centralized performance monitoring system for all of its
> wire protocols, including CIFS, and requires entry points into the SMBD
> process for gathering interesting SMB message characteristics such as
> the per-command message size, command, sub-command, some specific
> ioctls, response latency, and the connected identity.  This patch adds a
> pluggable module system to gather that data. 

In general, I like that idea a lot. Two points though:

Quick question: Why couldn't you extend the existing
(probably really bit-rotten) profile stuff under profile/?
To me it seems that this at least has similar goals,
although with some different information.

Another thing: Can you add a module that outputs information
similar to the existing profile/ code (not that I have used
that in years). If we get that, IMO we could dump the
existing stuff and replace it with something actually
supported and used. Ideally, this would use the perfmon
registry code.

Thanks,

Volker
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20090205/4fce049f/attachment.bin