Make schannel not depend on samdb anymore. (was Re: [SCM] Samba Shared Repository - branch master updated - release-4-0-0alpha6-317-g1dc745e)

simo simo at samba.org
Mon Feb 2 04:08:18 GMT 2009


On Mon, 2009-02-02 at 14:59 +1100, Andrew Bartlett wrote:
> On Mon, 2009-02-02 at 03:54 +0000, simo wrote:
> > On Mon, 2009-02-02 at 11:06 +1100, Andrew Bartlett wrote:
> > > On Sun, 2009-02-01 at 12:08 -0600, Simo Sorce wrote:
> > > > The branch, master has been updated
> > > >        via  1dc745ec895181af84998c1451ebffc7d3ba2081 (commit)
> > > >        via  10c907bcdb5856feb15bd6b096254ea5d112a8c9 (commit)
> > > >       from  c14b7e648bcfc4865da4b290e46977fff81d4500 (commit)
> > > > 
> > > > http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
> > > > 
> > > > 
> > > > - Log -----------------------------------------------------------------
> > > > commit 1dc745ec895181af84998c1451ebffc7d3ba2081
> > > > Author: Simo Sorce <idra at samba.org>
> > > > Date:   Sun Feb 1 13:06:38 2009 -0500
> > > > 
> > > >     Make schannel not depend on samdb anymore.
> > > 
> > > I'm confused, why do we have to duplicate these functions?
> > 
> > They are not really duplicated, they were just wrapper functions that
> > were unnecessarily dragging in a whole subsystem for nothing.
> > 
> > I am trying to clean up deps to avoid the jungle of dependencies we have
> > now. The goal is to be able to give openchange just the "client"
> > libraries they need without having to drag in the whole samba4 "server"
> > code.
> 
> Sure.  I just expected you would find/create another lib to shuffle them
> along to, that's all.

I thought about that, but the meat there is really just the ndr libs, it
seemed just too much to build a whole new helper library for 2 wrapper
functions. We can always rename and move the 2 I put in schannel_state
someplace else if it turns out other code ends up needing something
similar.

Simo.

-- 
Simo Sorce
Samba Team GPL Compliance Officer <simo at samba.org>
Principal Software Engineer at Red Hat, Inc. <simo at redhat.com>



More information about the samba-technical mailing list