[PATCH] make --control effectivly work in ldbadd/ldbmodify/ldbdelete

simo idra at samba.org
Mon Dec 28 08:09:08 MST 2009


On Mon, 2009-12-28 at 14:20 +0300, Matthieu Patou wrote:
> Hello Simo,
> 
> So it seems that metze has some compilation options stricter than the 
> default one of configure --enable-developper
> 
> So I refactored the patch to make it pass against the build lines he 
> provided.
> 
> 
> On 23/12/2009 18:37, simo wrote:
> > On Wed, 2009-12-23 at 16:16 +0100, Stefan (metze) Metzmacher wrote:
> >>
> >>
> >> And also there's a variable declaration after code in ldbdel.c
> >>
> >> Please fix or revert the changes, thanks:-)
> >
> > Thanks Metze,
> > pushed patches to fix this.
> >
> > Matthieu,
> > it would be nice if you'd actually at least compile once before
> > submitting patches.

Matthieu,
your patches have been committed and fixes to them have been committed
days ago.

Thanks.
Simo.

-- 
Simo Sorce
Samba Team GPL Compliance Officer <simo at samba.org>
Principal Software Engineer at Red Hat, Inc. <simo at redhat.com>



More information about the samba-technical mailing list