[PATCH] make --control effectivly work in ldbadd/ldbmodify/ldbdelete

[Stefan (metze) Metzmacher]

simo schrieb:
> On Wed, 2009-12-23 at 01:45 +0300, Matthieu Patou wrote:
>> The same but with a proper ldbutil.h instead of #include ldbutil.c
>>
>>
>>
>>
>> On 23/12/2009 01:16, Matthieu Patou wrote:
>>> Hello,
>>>
>>> Find attached 2 patches:
>>>
>>> * 1 for effectively passing the controls to the ldb subsystem in
>>> ldbadd/ldbmodify/ldbdelete
>>> * 1 for testing that behavior
>>>
>>> It's also available in the branch misc at
>>> http://repo.or.cz/w/Samba/ekacnet.git
>>>
>>> Matthieu.
> 
> Pushed to master.

I'm getting this now:

Compiling lib/ldb/tools/ldbutil.c
lib/ldb/tools/ldbutil.c: In function 'ldb_do_autotransaction':
lib/ldb/tools/ldbutil.c:57: error: implicit declaration of function
'ldb_asprintf_errstring'
lib/ldb/tools/ldbutil.c: At top level:
lib/ldb/tools/ldbutil.c:65: warning: no previous prototype for
'ldb_add_ctrl'
lib/ldb/tools/ldbutil.c:96: warning: no previous prototype for
'ldb_delete_ctrl'
lib/ldb/tools/ldbutil.c:122: warning: no previous prototype for
'ldb_modify_ctrl'
The following command failed:
ccache gcc -Wc++-compat -fstrict-aliasing -Wstrict-aliasing=2
-fstrict-overflow -Wstrict-overflow=5 -Wmissing-prototypes -g
-DDEBUG_PASSWORD -DDEVELOPER -Wall -Wshadow
-Werror-implicit-function-declaration -Wstrict-prototypes
-Wpointer-arith -Wcast-qual -Wcast-align -Wwrite-strings
-Wmissing-format-attribute -Wformat=2 -Wdeclaration-after-statement
-Wunused-macros -Wno-format-y2k -Wno-unused-parameter -Ilib/ldb
-Ilib/ldb/include -Ilib/ldb/include -Ilib/ldb/include -Ilib/ldb/include
-Ilib/ldb/include -Ilib/ldb/include -Ilib/ldb/include
-Iheimdal/../heimdal_build -Iheimdal/lib/hdb -Iheimdal_build
-Iheimdal/lib/roken -Iheimdal/lib/hdb -Ilib/ldb/include
-Ilib/ldb/include -Ilib/ldb/ldb_tdb -Ilib/ldb/include -Ilib/ldb/include
    -Iheimdal/../heimdal_build -Iheimdal/lib/gssapi
-Iheimdal/lib/gssapi/gssapi -Iheimdal/lib/gssapi/spnego
-Iheimdal/lib/gssapi/krb5 -Iheimdal/lib/gssapi/mech -Iheimdal/lib/gssapi
-Iheimdal/lib/gssapi     -I../lib/tdb/include  -I./../lib/talloc
-Iheimdal/../heimdal_build -Iheimdal/lib/krb5 -Iheimdal/lib/asn1
-Iheimdal/lib/com_err   -Iheimdal/../heimdal_build -Iheimdal/lib/hx509
-Iheimdal/lib/hx509 -Iheimdal/lib/asn1 -Iheimdal/lib/asn1
-Iheimdal/lib/asn1 -Iheimdal/lib/hx509 -Iheimdal/../heimdal_build
-Iheimdal/lib/hcrypto -Iheimdal/lib -Iheimdal/../heimdal_build
-Iheimdal/lib/hcrypto/imath -Iheimdal/../heimdal_build
-Iheimdal/lib/wind -Iheimdal/lib/asn1 -Iheimdal/lib/asn1
-Iheimdal/lib/asn1 -Iheimdal/lib/asn1 -Iheimdal/../heimdal_build
-Iheimdal/lib/asn1 -Iheimdal/../heimdal_build -Iheimdal/lib/com_err
-Iheimdal/../heimdal_build -Iheimdal/lib/roken -Iheimdal/include
-I../lib/socket_wrapper   -Ilib/events  -Wc++-compat -fstrict-aliasing
-Wstrict-aliasing=2 -fstrict-overflow -Wstrict-overflow=5
-Wmissing-prototypes -g   -I../lib/tevent   -I../lib/talloc
-Ilib/replace     -fPIC -I./include -I. -I./lib -I./../lib/replace
-I./../lib/talloc -I./.. -D_SAMBA_BUILD_=4 -DHAVE_CONFIG_H  -c
lib/ldb/tools/ldbutil.c -o lib/ldb/tools/ldbutil.o
make: *** [lib/ldb/tools/ldbutil.o] Error 1


And also there's a variable declaration after code in ldbdel.c

Please fix or revert the changes, thanks:-)

metze

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 260 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20091223/a811f132/attachment.pgp>