[PATCH] Proposed merge of some NTLMSSP crypto

[Andrew Bartlett]

On Sat, 2009-12-19 at 11:32 +0100, Kai Blin wrote:
> On Friday 11 December 2009 11:32:38 Andrew Bartlett wrote:
> 
> > To be clear, while I understand your suggestion, the next patch I do
> > won't follow the steps you propose, but I'll mention here when it's
> > done, and it can be accepted, rejected or reworked (Kai has offered to
> > help on that) on it's merits at that time.
> 
> Ok, so after a solid 7 hours of watching code compile or fixing it if it 
> doesn't compile,
> 
> http://gitweb.samba.org/?p=kai/samba/wip.git;a=shortlog;h=refs/heads/ntlmssp-
> compile
> 
> (or the ntlmssp-compile branch in git://git.samba.org/kai/samba/wip.git) Has a 
> patchset that at least compiles at every step. I'm not sure if the code 
> actually works (as in passes make test), as that would have taken even longer.

From my reading of the branch, there are still quite a few patches that
would need to be squashed to make this compile at each step - the
changes to the challenge generation code in Samba4 is still split out
over multiple patches, and some of the Samba4 callers are still fixed up
after the API changes. 

But regardless, thankyou so much for your efforts to try and harmonise
the patch stream, I do really appreciate it.  

My simple approach, given the change of approach mid-stream and the
requirements stated for bisect-ability (from must merging the sign code,
to merging the whole structure and server) would have been to produce 3
patches of: 
 - easily separable pre-work
 - establish common API
 - make Samba3 and Samba4 use common API

> Just as a comparison, I'd like to take the final version these patches arrive 
> at and try to reach the same stage using the steps metze proposed. That should 
> allow us to compare which method generates the more readable patches in what 
> time-scale. I'll drop an email to samba-technical once I'm done with that.

You are a glutton for punishment, but thank you very much!

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Cisco Inc.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20091221/0d65fa7a/attachment.pgp>