[PATCHS]: parsing get_dfs_referral messages

[Matthieu Patou]

Hi Matthias,
> Hi ekacnet,
>
> nice work! In general do you have all newer patches written by you in 
> your repo? As you know this simplifies the review and merge procedure 
> much.
>
> A first suggestion: please be a bit careful with code intendation,  
> e.g. this we don't like that much (in C we generally prefer tabs, in 
> python spaces but also tabs - but we try to don't mix them in the same 
> file).
>> +               typedef struct {
>> +               uint16  size;
>> +               uint16  server_type;
>> +               uint16  entry_flags;
>> +               nstring *share_name;
>> +       } trans2_dfs_referral_v1;
> It's useful to consider always first the commit DIFFs to fix those 
> "cosmetics" or remove unwanted cruft (using "gitweb", "gitk", "git 
> show" or "git diff") before publishing here or on IRC.
Thanks for pointing this matthias ! I already changed this in the repo. 
In fact I'm not hopping to get this patch right from the first shot but 
more to get information in what is not correct.

Matthieu.
>
> For the content I would invite someone skilled with the s4 file server 
> to answer.
>
> Matthias
>
> Matthieu Patou wrote:
>> Hello,
>>
>> Please in my repo: http://repo.or.cz/w/Samba/ekacnet.git branch msdfs 
>> from HEAD to  5ca793e  a bunch of patch for parsing get_dfs_referral 
>> message.
>>
>> * 0001-pidl-Introduce-new-dirrective-relative_short.patch, this patch 
>> introduce the relative_short directive which is the same as the 
>> relative on but with an offset stored in 2 bytes. It's needed because 
>> DFS_REFERAL messages have such kind of offset ( 
>> http://msdn.microsoft.com/en-us/library/cc227017%28PROT.10%29.aspx)
>>
>> * 0002-pidl-create-trans.idl-IDL-for-TRANSACTIONS2-extensio.patch, 
>> this is the IDL for the TRANSACATIONS2 extension which support the 
>> call get_dfs_referral
>> * 0003-torture-torture-tests-for-get_dfs_referral-of-trans..patch, a 
>> small torture test to check that we are able to pull from a known 
>> get_dfs_referral message and also that we are able to push the result 
>> to get the identical blob
>> * 0004-idl-add-generated-code.patch
>>
>>
>> Let me know.
>>
>> Matthieu.
>>
>>
>>
>>
>