[PATCH] Proposed merge of some NTLMSSP crypto

[Volker Lendecke]

On Wed, Dec 09, 2009 at 08:45:03AM +1100, Andrew Bartlett wrote:
> > e8d4e5d3e260726c9 does not compile for me, does it for you?
> 
> Yes, that compiled for me, and kblin reports it compiles for him after
> a ./config.status. 

Hmm.

Looking at

libcli/auth/ntlmssp_sign.h in lines 96ff I find the prototype

NTSTATUS ntlmssp_unseal_packet(struct ntlmssp_sign_state *ntlmssp_sign_state,
                               uint8_t *data, size_t length, 
                               const uint8_t *whole_pdu, size_t pdu_length, 
                               const DATA_BLOB *sig);

In source3/libsmb/smb_seal.c in lines 88ff I find a call

        status = ntlmssp_unseal_packet(&ntlmssp_state->crypt,
                                       tmp_ctx, 
                (unsigned char *)inbuf + 8 + NTLMSSP_SIG_SIZE, /* 4 byte len + 0xFF 'E' <e\
nc> <ctx> */
                data_len,
                (unsigned char *)inbuf + 8 + NTLMSSP_SIG_SIZE,
                data_len,
                &sig);

If I count the number of arguments in smb_seal.c, I count 7.
The prototype only has 6 parameters. Are we talking about
the same code?

Volker
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20091208/62f4198f/attachment.pgp>