scannedonly vfs module ported to samba 3.5

Olivier Sessink oliviersessink at gmail.com
Mon Dec 7 06:59:02 MST 2009


> Well, that's a bit hard to argue against :-)

back to the latest version. There was a question I had, can you comment on this?

thanks,
  Olivier

>    Then the active_files[1024] array in struct Tscannedonly: My
>   impression is that these are used to notify the scanner at
>    close time. Is that right? If so, you can't restrict that to
>   1024, we have to deal with many more file descriptors. Then,
>  with your "memset(so->activefiles, 0, 1024);" you don't
>    initialize the whole array if that was your intention.
>    1024*sizeof(char *) would have been right I think.

>    If my assumption about its purpose (use it at close time) is
>    right, then you don't need the array at all: We have the
>    fsp->fsp_name available in the vfs_close call that you might
>    want to access.

this makes the code a lot easier indeed. However, only need to notify
the anti-virus scanner if the file was opened in write or read/write
mode. Is that also accessible somewhere during file close?


More information about the samba-technical mailing list