[PATCH] lib/tdb: new locking hook.

Rusty Russell rusty at rustcorp.com.au
Fri Aug 28 18:41:37 MDT 2009

On Sat, 29 Aug 2009 12:13:21 am Stefan (metze) Metzmacher wrote:
> Rusty Russell schrieb:
> > On Fri, 28 Aug 2009 09:59:51 pm simo wrote:
> >> On Fri, 2009-08-28 at 11:59 +0930, Rusty Russell wrote:
> >>> This obsoletes the *mark and *nonblock calls, by allowing the user
> >>> to do fancy work replacing, recording or faking fcntl locks.  This
> >>> should make ctdb's life easier.  Clumsily, this also fixes a shadow
> >>> warning (wait) introduced by previous patch.
> >> This patch includes new functionality in tdb, please increase by one the
> >> Y version so that we can use the correct configure tests to satisfy the
> >> dependency in code that needs it.
> > 
> > OK.  I'll hold off: I'd prefer to do the changes for TDB_ALLOW_NESTING and
> > this back-to-back, so we only need inc the number once.
> With the current change only b needs to be changed in a.b.c.
> While the TDB_ALLOW_NESTING may need to change a.
> And only changing a makes trouble and should not happen often.


I also want to get rid of *_mark and *_nonblock (except
tdb_increment_seqnum_nonblock).  While I'm pretty sure only ctdb uses those,
but if we're going to do a major inc, we might as well do that too.


More information about the samba-technical mailing list