[PATCH] lib/tdb: locking cleanup

Rusty Russell rusty at rustcorp.com.au
Fri Aug 28 01:43:57 MDT 2009


On Fri, 28 Aug 2009 03:53:16 pm Andrew Bartlett wrote:
> On Fri, 2009-08-28 at 14:43 +0930, Rusty Russell wrote:
> > I use libtap, which creates simple one-line-per-test output (the TAP output
> > format is standardized see testanything.org)
> 
> Any chance you can use the subunit format already used by other parts of
> Samba?  (Samba4's 'make test' in particular). 
> 
> We have formatters and test parsers built around this format already.

(Replying here for benefit of archives and everyone else, after IRC discussion)

I'd never seen the subunit format; I don't like it as much (TAP is 1 per line)
but I don't really mind since:
1) We already use tap2subunit for the perl tests, and 
2) The libtap interface could easily also produce subunit output.

I'll create something which spits out subunit, and post once it's don
(am on vacation for three weeks, so might be a while!)

Thanks!
Rusty.


More information about the samba-technical mailing list