[PATCH] lib/tevent: remove spectacularly complicated manual subtraction

Rusty Russell rusty at rustcorp.com.au
Thu Aug 27 04:27:18 MDT 2009

On Thu, 27 Aug 2009 11:37:46 am tridge at samba.org wrote:
> In Samba we have historically not assumed that uint32_t is exactly 32
> bits, instead we have assumed it is at least 32 bits.

I realize this is now ancient history, but you really should have called it
something else then.  uint32_t is defined to be 32 bits in ISO C, and so it's
amazingly confusing for newcomers like me!

I know you guys love libreplace, but there are some lines you just can't
sanely cross, like replacing pread and pwrite with seek & read/write.  You've
complained about glibc doing similar to pselect, IIRC :)

> so in fact your patch would be fine with current lib/replace :-)

I *did* actually write a test program to make sure I wasn't missing some
horrible subtlety.  Esp. when I saw you were the original author :)


More information about the samba-technical mailing list