First writings on DsGetNCChanges call

[Anatoliy Atanasov]

Hi Metze,
> -----Original Message-----
> From: Stefan (metze) Metzmacher [mailto:metze at samba.org]
> Sent: Thursday, August 27, 2009 10:31
> To: Anatoliy Atanasov
> Cc: tridge at samba.org; samba-technical at lists.samba.org; abartlet at samba.org
> Subject: Re: First writings on DsGetNCChanges call
> 
> Anatoliy Atanasov schrieb:
> > I fixed it, thanks.
> >
> > I also fixed the usage of dsdb_attribute_ldb_to_drsuapi function so now
> it returns properly.
> >
> > There is still the problem with the call to
> dsdb_syntax_FOOBAR_ldb_to_drsuapi in
> source4/dsdb/schema/schema_syntax.c:735 (commit 6488afaa). The DSSYNC test
> passes when I remove that call.
> 
> I think you should also add the extended dn search control to the search
> so that the dsdb_syntax_DN_ldb_to_drsuapi can contrust the full
> drsuapi_DsReplicaObjectIdentifier3 structure.

Ok, I didn't see how to do that easily so I'll ask if this I right	Ldb_build_search_request
	ldb_request_add_control
	ldb_request

> 
> You also need to filter non-replicated attributes and setup the metadata
> array.
Sure, I'll just have to figure out how to do that.

Thanks,
Anatoliy

> 
> metze
> >> -----Original Message-----
> >> From: tridge at samba.org [mailto:tridge at samba.org]
> >> Sent: Wednesday, August 26, 2009 05:07
> >> To: Anatoliy Atanasov
> >> Cc: abartlet at samba.org; metze at samba.org; samba-
> technical at lists.samba.org
> >> Subject: Re: First writings on DsGetNCChanges call
> >>
> >> Hi Anatoliy,
> >>
> >>  > I uploaded the work-in-progress branch here:
> >>
> http://repo.or.cz/w/Samba/aatanasov.git?a=shortlog;h=refs/heads/samba_drsu
> >> api
> >>
> >> thanks for posting this!
> >>
> >> It looks like in your dcesrv_drsuapi_DsGetNCChanges() call you do a
> >> full search of the directory every time, pulling all records?
> >>
> >> Just using a search of (uSNChanged>=N) would be a big improvement in
> >> terms of memory consumption. It will still be slow in the backend, as
> >> the tdb backend doesn't actually use the indexes for a >= search, but
> >> at least the DRS server wouldn't have to parse all the records.
> >>
> >> Cheers, Tridge
>