[SCM] Samba Shared Repository - branch master updated - release-4-0-0alpha8-861-g457191e

Tim Prouty tprouty at samba.org
Fri Aug 7 11:05:19 MDT 2009

I don't remember exactly what we agreed upon for the process of
backporting bug fixes to maintenance releases, but I think it was
something like, get the patch signed off by someone else, and then
Karolin will actually do the pushing.  Does that sound right?

3121249243f52dcbf8083f5ff137bd580515efa7 allowed us to correctly
handle renaming directories when a client has files open underneath
it, but it also introduced a bug.  If a client holds open a handle to
the directory, and then tries to rename it, the rename should be
allowed, but in 3.4.x the client will get NT_STATUS_ACCESS_DENIED.  We
have already seen a few instances of SMB clients doing this in the
field, and customers seeing this seemingly random

The attached patches fix the problem against v3-4-test and add a
regression test so it's not broken by any future patches.  The fix is
slightly different in 3.4 than it was for master due to the
smb_filename changes.

Karolin, let me know if you would like me to push these myself, once I  
an ack.


On Aug 6, 2009, at 6:01 PM, Tim Prouty wrote:

> The branch, master has been updated
>       via  457191e9f396898b8a511cf860f24986f36fd879 (commit)
>       via  09e9904f18634b135944f466c48c4be1a43b4272 (commit)
>      from  890dfe003c91f8df737e5e2e4e440e1a9f416ae8 (commit)
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
> - Log  
> -----------------------------------------------------------------
> commit 457191e9f396898b8a511cf860f24986f36fd879
> Author: Tim Prouty <tprouty at samba.org>
> Date:   Thu Aug 6 15:53:33 2009 -0700
>    s3: Fix a bug in renames of directories

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-s3-Fix-a-bug-in-renames-of-directories.patch
Type: application/octet-stream
Size: 1946 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20090807/17495a19/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-s4-torture-Extend-the-RAW-RENAME-test-to-more-fully-.patch
Type: application/octet-stream
Size: 3053 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20090807/17495a19/attachment-0001.obj>

More information about the samba-technical mailing list