s4: Torture test for enhancements in "netr_LogonGetDomainInformations" call

[Andrew Bartlett]

On Tue, 2009-08-04 at 18:48 +0200, Matthias Dieter Wallnöfer wrote:
> Hi Andrew!
> 
> Matthias Dieter Wallnöfer schrieb:
> > Hi Andrew!
> >
> > Andrew Bartlett schrieb:
> >> On Mon, 2009-08-03 at 02:47 -0500, mdw at samba.org wrote:
> >>  
> >>> The branch, master has been updated
> >>>        via  720b7ea0ee77ffc8a3d59d3185cb0edd999b1c84 (commit)
> >>>        via  c688d374971cbd2de8e4be229422d00d383937f6 (commit)
> >>>        via  721402b8de9a94c4a7ca6ed2f039d0fe42f53351 (commit)
> >>>        via  e14b2ed8df12c1dadf907b96c5d6eb9192daa844 (commit)
> >>>       from  c50dff4ccea48de81815e0b92066b89b2bf3ddec (commit)
> >>>
> >>> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
> >>>
> >>>
> >>> - Log -----------------------------------------------------------------
> >>> commit 720b7ea0ee77ffc8a3d59d3185cb0edd999b1c84
> >>> Author: Matthias Dieter Wallnöfer <mwallnoefer at yahoo.de>
> >>> Date:   Thu Jul 23 13:05:34 2009 +0200
> >>>
> >>>     s4: Torture test for enhancements in 
> >>> "netr_LogonGetDomainInformations" call
> >>>         This corrects and enhances the torture test of the mentioned 
> >>> call.
> >>>     
> >>
> >> Did this pass 'make test' for you?
> >>
> >> Also, what version of Windows did you test it against?  I get failures
> >> against Windows 2008.  I fixed the 'make test' issue today, and
> >> partially fixed it against Windows 2008 in a commit I made today, but I
> >> need you to check it with what you tested against.
> >>
> >> I'll try to get Windows 2008R2 into my test environment soon.
> >>   
> > I found the problem: You run it through "ncalrpc", I through 
> > "ncacn_np". If I run it through "ncalrpc" I also get stacktraces. Will 
> > see how to fix it.
> >
> > Matthias
> >
> I worked this out now: 
> http://repo.or.cz/w/Samba/mdw.git?a=commitdiff;h=7b05ead24a82e35c69ed661df6380169c24116b5
> 
> Are you satisfied with it? Maybe you see some differences with Windows 
> Server 2008 (R2) so there could be some places where we've to adapt it a 
> little bit.

Honestly, I'm not really happy with the idea of going out over TCP (even
to localhost) when we are told to use a local ncaclrpc socket - that's
why I made it skip in that case.  'make test' will still check both, so
we will cover the 'double check with LDAP' code.

Andrew Bartlett

-- 
Andrew Bartlett
http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Cisco Inc.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20090805/fb01e8b8/attachment.pgp>