s4: Torture test for enhancements in "netr_LogonGetDomainInformations" call

[Matthias Dieter Wallnöfer]

Hi Andrew!

Andrew Bartlett schrieb:
> On Mon, 2009-08-03 at 02:47 -0500, mdw at samba.org wrote:
>   
>> The branch, master has been updated
>>        via  720b7ea0ee77ffc8a3d59d3185cb0edd999b1c84 (commit)
>>        via  c688d374971cbd2de8e4be229422d00d383937f6 (commit)
>>        via  721402b8de9a94c4a7ca6ed2f039d0fe42f53351 (commit)
>>        via  e14b2ed8df12c1dadf907b96c5d6eb9192daa844 (commit)
>>       from  c50dff4ccea48de81815e0b92066b89b2bf3ddec (commit)
>>
>> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
>>
>>
>> - Log -----------------------------------------------------------------
>> commit 720b7ea0ee77ffc8a3d59d3185cb0edd999b1c84
>> Author: Matthias Dieter Wallnöfer <mwallnoefer at yahoo.de>
>> Date:   Thu Jul 23 13:05:34 2009 +0200
>>
>>     s4: Torture test for enhancements in "netr_LogonGetDomainInformations" call
>>     
>>     This corrects and enhances the torture test of the mentioned call.
>>     
>
> Did this pass 'make test' for you?
>   
For sure. Otherwise I wouldn't have pushed it.
> Also, what version of Windows did you test it against?  I get failures
> against Windows 2008.  I fixed the 'make test' issue today, and
> partially fixed it against Windows 2008 in a commit I made today, but I
> need you to check it with what you tested against.
>
> I'll try to get Windows 2008R2 into my test environment soon.
>   
I tested against Windows Server 2003 R2 (also mentioned in the mail 
against Microsoft).
>   
>> commit c688d374971cbd2de8e4be229422d00d383937f6
>> Author: Matthias Dieter Wallnöfer <mwallnoefer at yahoo.de>
>> Date:   Wed Jul 22 22:11:12 2009 +0200
>>
>>     s4: Enhancements in the "netr_LogonGetDomainInformations" call
>>     
>>     This addresses bug #4888 and #6596 in SAMBA 4 Bugzilla
>>     - It implements the call in the complete form as specified in the MSPP/WSPP docs
>>       and on the discussion on the "cifs-protocol" list
>>     - Therefore client informations (OS name, OS version, "servicePrincipalName"...)
>>       are now saved in the AD each time the client invokes the call
>>     
> Out of interest, what platform do you develop on?  I had segfaults in
> that server code, due to the way you used gendb_search_string().  
>
> I'm wondering if it's on OS-specific thing, or just something that you
> missed in a late change.
>   
Could be, could be. Good, that you found out the leak. On my environment 
(Ubuntu 6.06 LTS 32 bit) it never broke - otherwise I'd have changed it.
> Andrew Bartlett
>
>