[PATCH] Have the smbcli_session record the OS and Native LANMAN of the remote server

Gerald Carter jerry at plainjoe.org
Thu Apr 30 15:11:14 GMT 2009

Hash: SHA1

Hey Sam,

> I'm not picking fault here, or trying to argue; just 
> pointing out how it looks from my position.
> The documents you mention encourage the style I 
> used, and do not discourage it, apart from tab-8
> spacing which no-one follows.
> The two documents you mention make recommendations 
> that are not followed even in new code.
> In short, they can't be trusted, it seems that they 
> misled me and are somewhat ignored by everyone else.

I think you make some really good points.  Let me try to

(a) If you followed the documented coding guidelines,
    and they led you astray, then I concede.  The fault
    is in the documentation and should be updated.  No one
    can ding you for doing what the docs asked you to do.

(b) There may be a disconnect between the docs provided
    to encourage new Samba developers and those that
    have spent many cycles under an apprenticeship with
    long term Samba developers.  New in this sense means
    that one doesn't have the sense of history of the
    project's lifetime.

The conclusion then would be that if participating in Samba
development requires some type of personal guidance from
an established developer on issues of coding style and
tradition, then this will have scaling issues due to the
number and time of existing core devs.

This is all just personal philosophy from me.  I can't
speak for everyone, but it has given me some points to

cheers, jerry
- --
http://git.plainjoe.org/                                         CODE
"What man is a man who does not make the world better?"      --Balian
Version: GnuPG v1.4.9 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org


More information about the samba-technical mailing list