[PATCH] Change unix_convert to use struct smb_filename

Volker Lendecke Volker.Lendecke at SerNet.DE
Thu Apr 30 10:04:18 GMT 2009

On Tue, Apr 28, 2009 at 02:30:11PM -0700, Tim Prouty wrote:
> NTSTATUS unix_convert(TALLOC_CTX *ctx,
> 		      connection_struct *conn,
> 		      const char *orig_path,
> 		      struct smb_filename *smb_fname,
> 		      uint32_t ucf_flags)

Just a quick stylistic question: Why not allocate the
smb_filename struct in unix_convert and have the substrings
as talloc children off that? In case this turns out to be a
malloc performance hit, we can always do the appropriate
talloc_pool trick inside unix_convert.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20090430/13207921/attachment.bin

More information about the samba-technical mailing list