[PATCH] Change unix_convert to use struct smb_filename

Jeremy Allison jra at samba.org
Wed Apr 29 23:39:29 GMT 2009

On Tue, Apr 28, 2009 at 03:56:12PM -0700, Jeremy Allison wrote:
> On Tue, Apr 28, 2009 at 02:30:11PM -0700, Tim Prouty wrote:
> >
> > One key point here is the decision to break up the base_name and  
> > stream_name.  I have introduced a helper function called  
> > get_full_smb_filename() that takes an smb_filename struct and allocates 
> > the full_name.  I changed the callers of unix_convert() to subsequently 
> > call get_full_smb_filename() for the time being, but I plan to eventually 
> > eliminate get_full_smb_filename().
> >
> > I'm going to continue moving forward, but I would love any input or  
> > suggestions on the specifics of the data in the smb_filename struct, and 
> > the api moving forward.
> I really like the look of this - thanks ! But I'll spend some
> time reviewing it over the next day or so.

Sorry Tim, didn't get to this today, can I finish
reviewing tomorrow instead ?


More information about the samba-technical mailing list