[PATCH] Have the smbcli_session record the OS and Native LANMAN of the remote server

Volker Lendecke Volker.Lendecke at SerNet.DE
Wed Apr 29 16:24:37 GMT 2009


On Wed, Apr 29, 2009 at 05:06:19PM +0100, Sam Liddicott wrote:
> Some found by the above command are:
> 
> if (!(ctrl[i] = talloc(ctrl, struct ldb_control))) {

There was a time in Samba development where our
recommendations told us this is good. At some point this
changed again to the 

ctrl[i] = talloc(ctrl, struct ldb_control);
if (ctrl[i] == NULL) {
}

style for better debuggability. But obviously we did not
change all the code from in between.

Volker
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20090429/2374818d/attachment.bin


More information about the samba-technical mailing list