[PATCH] Have the smbcli_session record the OS and Native LANMAN of the remote server

Gerald Carter jerry at samba.org
Wed Apr 29 11:41:36 GMT 2009

Hash: SHA1

Hey Sam,

> The above disguises the intention in a tedium of 
> small operations, taking 8 lines, only two of
> which represent common execution behaviour.
> There's too little meaning, too little going on 
> to spread over eight lines.

I'm on the outside of this one, but I'll chime in anyways.

Coding style debates are a waste of time in my opinion.
Developers should optimize for the collective and not the
individual.  It is imperative for someone else to be able
to pick up your code and immediately understand it.
Diverging from the established conventions of the large
body of code is just a distraction.

If it were me, I would rather not worry about the cosmetics
and my own personal style.  I would want the functional
change accepted into upstream.   Currently there's an
established coding convention that has obviously not been

But the final decision is not mine, so take this for what
it's worth.

cheers, jerry
- --
http://git.plainjoe.org/                                         CODE
"What man is a man who does not make the world better?"      --Balian
Version: GnuPG v1.4.9 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org


More information about the samba-technical mailing list