RFC [PATCH]: ignore recurisve change notify

Steven Danneman steven.danneman at isilon.com
Wed Apr 22 10:57:04 GMT 2009


> On Tue, Apr 21, 2009 at 07:30:18AM -0700, Steven Danneman wrote:
> > Using Isilon's kernel change notify module on a very deep directory
> > structure can cause a significant slow down in the system.  This
> patch
> > allows Samba to ignore recursive CN requests while still honoring
> > non-recursive requests.  I could make this a custom parameter in the
> > onefs.so module, but I'm guessing this problem can also apply to
> > inotify and the stock Samba CN implementation.
> >
> >
> >
> > Any objections to adding this new parameter?
> 
> What about also modifying notify_internal not to handle the big
record?
> This would make it possible to "tune" only some of the smbd's but
leave
> others with the full recursive record around.
> 
> Volker

You're proposing something like a "change notify restrict recursive"
where 
we'd still allow recursive calls on smaller directory trees but
gracefully 
stop returning watch replies on larger directory trees?

I like the concept, though then we'd need to check the parameter in
every CN 
implementation instead of cleaning at the packet parsing layer.

-Steven


More information about the samba-technical mailing list