[PATCH] Fixed problem with schemaUpdateNow request.

[Andrew Bartlett]

On Fri, 2009-04-10 at 12:09 +0300, Nadezhda Ivanova wrote:
> Hi Samba,
> The attached patch contains the fix for the schemaUpdateNow request not working, + test. 
> Hopefully, we should now be able to modify the Schema via LDAP. 

Thanks,

The main issue I have with the test is that it does not pass against
Windows 2008:

test: Testing schemaUpdateNow works correctly
failure: Testing schemaUpdateNow works correctly [
Traceback (most recent call last):
  File "lib/ldb/tests/python/ldap.py", line 1127, in
test_schemaUpdateNow
    self.delete_force(self.ldb, "CN=ATest-Attribute1," + self.schema_dn)
  File "lib/ldb/tests/python/ldap.py", line 1051, in delete_force
    self.assertEquals(num, ERR_NO_SUCH_OBJECT)
AssertionError: 50 != 32
]

This makes it very difficult to prove that the behaviour is correct.

Given that we cannot (in AD, as I understand it) delete objects, we
should create them with a (more) unique name, and disable them when we
are finished.  We should also add and test this behaviour in Samba4.

Andrew Bartlett

-- 
Andrew Bartlett
http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Red Hat Inc.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20090414/2e4363aa/attachment.bin