[SCM] Samba Shared Repository - branch master updated - release-4-0-0alpha7-1005-ge9569ae

[Andrew Bartlett]

On Mon, 2009-04-13 at 09:36 +0200, Volker Lendecke wrote:
> On Mon, Apr 13, 2009 at 03:52:17PM +1000, Andrew Bartlett wrote:
> > > -		if (!convert_string_allocate(NULL, CH_UNIX, CH_UTF16LE,
> > > +		if (!convert_string_allocate(talloc_tos(), CH_UNIX, CH_UTF16LE,
> > >  			c->name, strlen(c->name)+1, &uni_name.buffer,
> > >  			&namelen, True) || (uni_name.buffer == NULL)) {
> > >  			goto fail;
> > 
> > Why not use convert_string_talloc() (which does exist in Samba3, even
> > without my recent work)? 
> 
> Done, thanks!

BTW, cleanups like this are the majority of the charcnv-minimal-merge
branch.  After abandoning the work to actually put the core code in
common, I did notice that this was a course already being taken, which
is why I persisted in submitting the remainder of the patch.   I'm very
grateful for the work GD had done to merge these so far.

Andrew Bartlett

-- 
Andrew Bartlett
http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Red Hat Inc.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20090413/5f27bc84/attachment.bin