[SCM] Samba Shared Repository - branch master updated - release-4-0-0alpha7-1005-ge9569ae

[Andrew Bartlett]

On Sat, 2009-04-11 at 04:07 -0500, Volker Lendecke wrote:
> The branch, master has been updated
>        via  e9569ae9250ac571c63fbb450709778a247e9ca3 (commit)
>        via  5fc9ca93f3f7f00198478b333d8e4ee036165121 (commit)
>        via  ea6094d2cbb6d96baa5db0a1cb3fdbc7f58d73e2 (commit)
>       from  2ff80f0d761680f3732a46c2672bcef041a7c367 (commit)
> 
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
> 
> 
> - Log -----------------------------------------------------------------
> commit e9569ae9250ac571c63fbb450709778a247e9ca3
> Author: Volker Lendecke <vl at samba.org>
> Date:   Thu Apr 9 15:51:35 2009 +0200
> 
>     Fix some nonempty blank lines
> 
> commit 5fc9ca93f3f7f00198478b333d8e4ee036165121
> Author: Volker Lendecke <vl at samba.org>
> Date:   Thu Apr 9 11:40:08 2009 +0200
> 
>     Fix a memleak in an unlikely error path in change_notify_create()
> 
> commit ea6094d2cbb6d96baa5db0a1cb3fdbc7f58d73e2
> Author: Volker Lendecke <vl at samba.org>
> Date:   Thu Apr 9 11:36:45 2009 +0200
> 
>     Use talloc_tos() for a temp convert_string_allocate()
> 
> -----------------------------------------------------------------------
> 
> Summary of changes:
>  source3/smbd/notify.c          |    7 ++++---
>  source3/smbd/notify_internal.c |    8 ++++----
>  2 files changed, 8 insertions(+), 7 deletions(-)
> 
> 
> Changeset truncated at 500 lines:
> 
> diff --git a/source3/smbd/notify.c b/source3/smbd/notify.c
> index fdab2ca..a17afc7 100644
> --- a/source3/smbd/notify.c
> +++ b/source3/smbd/notify.c
> @@ -81,7 +81,7 @@ static bool notify_marshall_changes(int num_changes,
>  
>  		c = &changes[i];
>  
> -		if (!convert_string_allocate(NULL, CH_UNIX, CH_UTF16LE,
> +		if (!convert_string_allocate(talloc_tos(), CH_UNIX, CH_UTF16LE,
>  			c->name, strlen(c->name)+1, &uni_name.buffer,
>  			&namelen, True) || (uni_name.buffer == NULL)) {
>  			goto fail;

Why not use convert_string_talloc() (which does exist in Samba3, even
without my recent work)? 

Andrew Bartlett

-- 
Andrew Bartlett
http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Red Hat Inc.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20090413/18312936/attachment.bin