Threading libsmbclient - a proposal.

Jeremy Allison jra at
Wed Apr 8 01:45:40 GMT 2009

On Wed, Apr 08, 2009 at 12:56:04AM +0000, simo wrote:
> Right, but thinking about that I am wondering if you shouldn't mark all
> functions as static ?

Yep - very good point ! I'll do that, thanks.

So I think I'm going to narrow the interface
down to be smb_create_mutex() not create_lock()
and remove the extra rw lock stuff so we don't
confuse callers who think there might be rw
locks available. We can always add these later
as we thread the code.

So I've got a couple of fixes to do, I'll
try and get to that tomorrow (I'm at the
LinuxFoundation conf up in San Francisco
the rest of the week).

Thanks for the review Simo, much appreciated.


More information about the samba-technical mailing list