Threading libsmbclient - a proposal.

Jeremy Allison jra at samba.org
Wed Apr 8 00:36:04 GMT 2009


On Wed, Apr 08, 2009 at 12:31:38AM +0000, simo wrote:
> 
> If you think you can add other types of locks later on without changing
> the public API I see no problem going step by step.
> But keep in mind that the huge macro (or my proposed define), moves all
> that code into the API.

No, actually it doesn't - that's the nice thing about it !

> If you later find you need to change that code you will have to break
> compatibility with all applications that built against that interface.

I'm trying to get the public API as correct as possible, so we
won't have to change it in the future. Source code will still
be compatible, as the definition of these functions can be
changed by any caller that uses the interface - the code
is just one sample implementation of the interface. You
could just as easily write Win32 code to implement the
same locking primitives (in fact the TLS interface was
based on the Win32 interface, not the pthread one).

Jeremy.


More information about the samba-technical mailing list