[SAMBA3] Really confused about convert_string returns

Jeremy Allison jra at samba.org
Wed Apr 1 00:00:57 GMT 2009

On Wed, Apr 01, 2009 at 10:22:37AM +1100, Andrew Bartlett wrote:
> While working on my failed attempt to merge the charcnv core (I still
> propose to merge the APIs), I was following the convert_string and
> convert_string_internal APIs.
> The use of the return value in this code is rather inconsistent, and I'm
> a little confused:
> Firstly, it does not seem to return -1 in the error cases (see patch).
> Even if it did, then in some other cases it has:
> return retval + convert_string_internal(...
> where retval can be an integer representing how many bytes have been
> converted in the the destination charset so far, but
> convert_string_internal() can return (size_t)-1!
> Is it presumed that retval + (size_t)-1 will always be -1?

That's a bug, I'll take a look at it.


More information about the samba-technical mailing list