Common code into source/ or toplevel? (Re: Suggested "combined tree" conditions for success)

Jelmer Vernooij jelmer at
Tue Sep 16 12:17:47 GMT 2008

On Mon, 2008-09-15 at 09:25 +0200, Stefan (metze) Metzmacher wrote:
> >>> Personally, I'm just waiting for the combined build system to hit so I
> >>> can start converting over the utilities I'm working on.
> >> you can already start, you just need to rebase
> >> (or git format-patch && git am) when the final branch is ready...
> > 
> > I'm waiting for being able to "make" in the root dir, but you're right. It 
> > should be possible to move the first utils now. I'm not short on todo list 
> > items, though, so I don't lose much by waiting for Jelmer's updated build 
> > system patch.
> As we now have the combined 'master' branch with source3/ and source4/
> sub directories, we can think about where to move common code
> and the build magic for a combined 'make'.
> I'd propose to move them to source/, to that all 3 ways of building
> code in the master branch have the same weight. I assume have the magic
> of the combined build in the top level directory would give more weight
> to the most experimental way of building samba.
> Comments please!
I would prefer to have the source code directly in the top-level
directory, at least the libraries (lib/tdb rather than source/lib/tdb).
Perhaps we can leave just the merged build configure + Makefile out of
the top-level source directory for now?



More information about the samba-technical mailing list