reversed test in nss_init
Gerald (Jerry) Carter
jerry at samba.org
Wed Sep 10 15:10:55 GMT 2008
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Herb,
This is incorrect. The check I believe is to skip plugins that
fail to init and continue processing the remaining ones in the
list.
cheers, jerry
Herb Lewis wrote:
>
> $ git-diff --unified=10
> diff --git a/source/winbindd/nss_info.c b/source/winbindd/nss_info.c
> index daa3dd0..96a2c77 100644
> --- a/source/winbindd/nss_info.c
> +++ b/source/winbindd/nss_info.c
> @@ -156,21 +156,21 @@ static bool parse_nss_parm( const char *config,
> char **backend, char **domain )
> DEBUG(0,("nss_init: failed to parse \"%s\"!\n",
> nss_list[i]));
> continue;
> }
>
> /* validate the backend */
>
> if ( (nss_backend = nss_get_backend( backend )) == NULL ) {
> /* attempt to register the backend */
> status = smb_probe_module( "nss_info", backend );
> - if ( !NT_STATUS_IS_OK(status) ) {
> + if ( NT_STATUS_IS_OK(status) ) {
> continue;
> }
>
> /* try again */
> if ( (nss_backend = nss_get_backend( backend ))
> == NULL ) {
> DEBUG(0,("nss_init: unregistered backend
> %s!. Skipping\n",
> backend));
> continue;
> }
>
- --
=====================================================================
Samba ------- http://www.samba.org
Likewise Software --------- http://www.likewisesoftware.com
"What man is a man who does not make the world better?" --Balian
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFIx+NmIR7qMdg1EfYRAnEbAJ9qA+uEv8OqYHSIi00HJU47s2GYCQCfee9X
JEBi5TRLvZuESjqRXKMqo3Q=
=NlFP
-----END PGP SIGNATURE-----
More information about the samba-technical
mailing list