Write times fix for S3
Stefan (metze) Metzmacher
metze at samba.org
Tue Sep 9 17:31:47 GMT 2008
Jeremy Allison schrieb:
> On Tue, Sep 09, 2008 at 08:35:27AM +0200, Stefan (metze) Metzmacher wrote:
>> Jeremy Allison schrieb:
>>> On Tue, Sep 09, 2008 at 12:57:12PM +1000, Andrew Bartlett wrote:
>>>> On Fri, 2008-09-05 at 19:00 -0700, Jeremy Allison wrote:
>>>>> Ok, here's the fix for the write times breakage
>>>>> with the new tests in S4 smbtorture.
>>>> Are you intending to fix Samba4's file server similarly?
>>> Not right now, I'm still working on torture tests to
>>> discover it Metze's comments are correct (they probably
>>> are :-).
>> I think most of your changes were indeed correct
>> and the v3-devel branch from yesterday evening (my time)
>> passes all tests I added yesterday.
> Well the thing I'm trying to understand is if doing
> a SET_END_OF_FILE, SET_ALLOCATION_SIZE or SMBwrite
> with zero length is a "sticky" write time set, or
> a "normal" write time set. That's the part of the
> data model I still need to understand (and will
> probe with more tests).
Your vision of the data model seems correct,
they update the normal write time. See
that demonstrates it for the SMBwrite
with zero length.
Feel free to add tests to demonstrate that
for SET_END_OF_FILE and SET_ALLOCATION_SIZE.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 252 bytes
Desc: OpenPGP digital signature
Url : http://lists.samba.org/archive/samba-technical/attachments/20080909/dbbf1cbd/signature.bin
More information about the samba-technical