Write times fix for S3

Jeremy Allison jra at samba.org
Mon Sep 8 21:58:22 GMT 2008

On Mon, Sep 08, 2008 at 07:48:11AM +0200, Stefan (metze) Metzmacher wrote:

> We don't need special cases for SMBwrite truncate.
> I think SMBwrite truncate, SET_END_OF_FILE and SET_ALLOCATION_SIZE
> just need to be handled like an explicit set of the write time.
> I'm adding some more code to the torture tests to verify this...

Ok, I'll test this and revert if this is the case. Would
make the code a lot simpler.

> It's correct that it's never reset! And subsequent SMBwriteX's doesn't
> update the write time!

Ack. Again, working on torture to check.

> Please don't apply your patch as it's not correct.
> We need more torture tests first, before we can think of the
> correct fix.

I'll revert back to your code with the addition of
set_write_time_fsp calls on SMBwrite truncate, SET_END_OF_FILE and
SET_ALLOCATION_SIZE if things seem to fit.



More information about the samba-technical mailing list