[PATCH] Cleanup of DC enumeration in get_dcs()

Jeremy Allison jra at samba.org
Thu Sep 4 18:48:13 GMT 2008

On Wed, Sep 03, 2008 at 08:09:08PM -0700, Steven Danneman wrote:
> I've been examining the winbindd_cm.c:cm_open_connection() path a lot
> lately and it's doing some pretty ugly things.  For example, in
> find_new_dcs() it's possible in the error case to enumerate all DCs in a
> domain, open a socket to all of them simultaneously, then on a single
> connection error to one of them start over from scratch, getting every
> DC again.
> This all works though, and seems to be pretty efficient in the common
> case, but when there's a problem everything gets really bad.  
> This is a first patch to clean up some of the redundancy in get_dcs().
> I've also gotten on a real Doxygen kick lately.

Looks good to me ! I'm pushing.


More information about the samba-technical mailing list