[SCM] Samba Shared Repository - branch v3-0-test updated - release-3-0-32-11-g0b39c04

[simo]

On Thu, 2008-09-04 at 09:37 -0700, Jeremy Allison wrote:
> On Thu, Sep 04, 2008 at 03:58:20PM +1000, tridge at samba.org wrote:
> > Hi Simo,
> > 
> >  > and please check with somebody who knows systems programming before
> >  > making a change like this.
> > 
> > also, my apologies for this. Kai and Andrew have now pointed me at the
> > thread where you asked about this, and got an ack from Jeremy.
> 
> Yes, as it was only on db expansion I thought this was
> ok as the alternative is data loss. Note that according
> to the man page without this we could potentially corrupt
> the tdb whilst in-use on every expansion, which seemed
> to be a case for using msync to me.
> 
> Please correct me if I'm wrong, but not doing it on
> clear-if-first db's could also potentially corrupt
> them whilst in use.
> 
> I don't think it's a big problem else we'd see many
> more corrupted tdb's than we do, so your thoughts on
> the matter would be most appreciated.


Btw, I will try to run a torture test as soon as I can and see if with
or without msync on expansion we see any noticeable difference.

Simo.

-- 
Simo Sorce
Samba Team GPL Compliance Officer <simo at samba.org>
Senior Software Engineer at Red Hat Inc. <simo at redhat.com>