[PATCH] Cleanup of DC enumeration in get_dcs()

Steven Danneman steven.danneman at isilon.com
Thu Sep 4 03:09:08 GMT 2008

I've been examining the winbindd_cm.c:cm_open_connection() path a lot
lately and it's doing some pretty ugly things.  For example, in
find_new_dcs() it's possible in the error case to enumerate all DCs in a
domain, open a socket to all of them simultaneously, then on a single
connection error to one of them start over from scratch, getting every
DC again.


This all works though, and seems to be pretty efficient in the common
case, but when there's a problem everything gets really bad.  


This is a first patch to clean up some of the redundancy in get_dcs().
I've also gotten on a real Doxygen kick lately.



-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Cleanup-of-DC-enumeration-in-get_dcs.patch
Type: application/octet-stream
Size: 8958 bytes
Desc: 0001-Cleanup-of-DC-enumeration-in-get_dcs.patch
Url : http://lists.samba.org/archive/samba-technical/attachments/20080903/2d44776c/0001-Cleanup-of-DC-enumeration-in-get_dcs.obj

More information about the samba-technical mailing list