[PATCH] tdb and msync

[simo]

On Wed, 2008-09-03 at 11:03 -0700, Jeremy Allison wrote:
> On Wed, Sep 03, 2008 at 02:58:30PM +0000, simo wrote:
> > I got a report here in Fedora bugzilla[1] about tdb missing to use msync
> > before a munmap operation.
> > Checking manpages it seem quite correct. 
> > 
> > I see we had a thread on this named: "changes to .tdb files lost"[2] in
> > Sept. 2005 where Volker also agrees that using msync() before an
> > munmap() is helpful.
> > 
> > I am not sure what impact on performances we might get this way,
> > tdb_munmap() seem to be called in quite a few places, but I guess it is
> > not used in critical paths anyway. Advice if not.
> > 
> > Please let me know if it is ok to commit this patch in all branches.
> 
> Patch looks good to me. I'd say commit. We don't really have
> a choice as data loss is the only alternative.

Thanks,
pushed.

Simo.

-- 
Simo Sorce
Samba Team GPL Compliance Officer <simo at samba.org>
Senior Software Engineer at Red Hat Inc. <simo at redhat.com>