[PATCH] i18n/l10n pam_winbind (Was: [RFC] i18n/l10n pam_winbind for samba 3.x)

boyang boyang at suse.de
Wed Oct 29 03:58:03 GMT 2008

Jeremy Allison wrote:
> On Tue, Oct 28, 2008 at 06:07:33PM +0800, boyang wrote:
>> Here is the patch for 3-0-test, please review it. I am not sure if I did
>> it right, therefore, I think I need some feedback before porting it to
>> 3-[23]-test, 3-devel and master. :-)  Thanks in advance! Here is the
>> major changes:
>> 1. add option to configure script to configure localedir, where
>> pam_winbind will look up .mo from, where .mo will be installed.
>> 2. link pam_winbind against dynconfig.o to make sure that pam_winbind
>> will get the correct path to .mo files
>> 3. add install/uninstall section in Makefile.in as well as installation
>> script(installmo.sh) for .mo files
>> 4. recommend to include one new directory under source to contain .po
>> files. For example, .po files for pam_winbind will be under directory
>> source/locale/pam_winbind/, which makes it easier for installing .mo files.
> Ok, I'll review this -  but this change isn't going into 3.0.x
> *anything* :-). This is a significant change, so we'll add
> it to 3.3.x and above only. Should make your porting job
> easier :-).
Sorry for my unclear words. I wish you have not look into the details of
the patch, which must waste your time. :-) My point here is whether the
framework is Ok. I only make sure that the patch compiles now, but I am
sure that it won't work at present. If the framework is Ok, I'll work on
the details of the patch to make sure it functions well. :-)
> Jeremy.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: boyang.vcf
Type: text/x-vcard
Size: 187 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20081029/9c6694b2/boyang.vcf

More information about the samba-technical mailing list