[PATCH] Change SMB_BIG_UINT to uint64_t

Jelmer Vernooij jelmer at samba.org
Tue Oct 14 00:08:57 GMT 2008

Hi Jeremy,

On Mon, 2008-10-13 at 16:44 -0700, Jeremy Allison wrote:
> On Sat, Oct 11, 2008 at 03:51:40PM +0200, Jelmer Vernooij wrote:
> > Since Samba 3 already requires {u,}int64_t to be around, it seems
> > pointless to have a separate type for it anymore, and it ends up being a
> > uint128_t (?) on 64-bit machines. This is one of the prerequisites of
> > sharing fsusage() between Samba 3 and Samba 4, since Samba 4 uses
> > uint64_t already.
> > 
> > The attached patch replaces all uses of SMB_BIG_{U,}INT with
> > {u,}int64_t.
> > 
> > If nobody objects to this patch, I'll push it to the master branch in a
> > couple of days.
> Ok, I've checked through this and I can't see anything too
> horrific that should break :-). We should uprev the VFS
> interface number though to ensure we don't break anything
> that was using the abstract type and to notify users of
> the change. Once you've pushed this change I'll do the
> VFS interface number change.
Thanks for reviewing. I'm pushing the change now, the revid is 4746f79.



Jelmer Vernooij <jelmer at samba.org> - http://samba.org/~jelmer/
Jabber: jelmer at jabber.fsfe.org

More information about the samba-technical mailing list