348be5f1e44c0 (Share data_blob implementation) breaks Samba3

[Andrew Bartlett]

On Sun, 2008-10-12 at 15:14 -0700, Jeremy Allison wrote:
> On Mon, Oct 13, 2008 at 08:59:36AM +1100, Andrew Bartlett wrote:
> > 
> > Or we can find out which bits rely on the different behaviours.  Why
> > does Samba3's smbd rely on a length-limited string being also NULL
> > terminated?
> 
> At a quick look it looks like the memcache code, which is
> quite recent. But there are also uses in rpc_server/srv_samr_nt.c
> which are RPC related.
> 
> The problem is the patch isn't complete as applied. It broke
> previously working code. 
> 
> I'm sure you wouldn't be pleased at changes that break
> the underlying S4 semantics without testing. This is the
> same. I think it needs reverting until such testing is
> done and the patch can be made complete.

Or fixed.  I wasn't arguing that, just wondering about the long-term
fix.

Does this kind of thing show up under 'make test'? 

Andrew Bartlett

-- 
Andrew Bartlett
http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Red Hat Inc.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20081013/8aeccec6/attachment.bin