[linux-cifs-client] Fwd: [PATCH] Fix CIFS compilation with CONFIG_KEYS unset

Jeff Layton jlayton at redhat.com
Sun Oct 12 20:16:34 GMT 2008

On Sun, 12 Oct 2008 11:57:47 -0500
"Steve French" <smfrench at gmail.com> wrote:

> On Sun, Oct 12, 2008 at 11:53 AM, Steve French <smfrench at gmail.com> wrote:
> > On Sun, Oct 12, 2008 at 8:59 AM, Jeff Layton <jlayton at redhat.com> wrote:
> >> On Sun, 12 Oct 2008 08:40:39 -0500
> >> "Steve French" <smfrench at gmail.com> wrote:
> >>
> >> Actually, I like Adrian/Rafael's fix better. I think we should avoid
> >> cluttering up the code with #ifdef's where possible. key_put() already
> >> is a no-op when CONFIG_KEYS is disabled. We might as well do the same
> >> thing with key_revoke().
> > I don't think it matters much - but we probably shouldn't be
> > overriding global functions.
> To clarify, I like fixing it in keys.h better than overriding it in
> cifs, but in the meantime we need an ifdef in cifs until keys.h
> changes.

It's your call, but if we're going to carry a temporary patch, then I'd
prefer to just carry the one that adds the empty key_revoke definition.
I don't think there's much benefit to changing the cifs code for this,
but I don't feel very strongly about it either way...
Jeff Layton <jlayton at redhat.com>

More information about the samba-technical mailing list