[PATCH] Reconcile arc4 implementations

Jelmer Vernooij jelmer at samba.org
Sat Oct 11 14:38:42 GMT 2008


On Sat, 2008-10-11 at 14:26 +1100, Andrew Bartlett wrote:
> On Sat, 2008-10-11 at 02:58 +0200, Jelmer Vernooij wrote:
> > The attached patch makes Samba 3 use the arc4 implementation from
> > lib/crypto. 
> > 
> > I think this is correct and it seems to work ok, but it would be nice if
> > somebody with a bit more crypto experience could give a quick look at
> > it.
> 
> It certainly looks reasonable to me.
Thanks! pushed.

>   The NTLMSSP code (ntlmssp_sign.c
> in particular) should be pretty close between the two branches (and is
> perhaps a future target for merging.
Unfortunately, that uses DEBUG() so can't be touched before we resolve
that (similar to lib/util/*)

Cheers,

Jelmer
-- 
Jelmer Vernooij <jelmer at samba.org> - http://samba.org/~jelmer/
Jabber: jelmer at jabber.fsfe.org



More information about the samba-technical mailing list