[linux-cifs-client] Re: [PATCH] mount.cifs: make return codes match the return codes for /bin/mount

Jeff Layton jlayton at redhat.com
Wed Oct 8 16:21:57 GMT 2008


On Wed, 08 Oct 2008 12:14:38 -0400
Jeff Moyer <jmoyer at redhat.com> wrote:

> Jeff Layton <jlayton at redhat.com> writes:
> 
> > The manpage for /bin/mount specifies that the return code should be a
> > positive integer (actually, it's a bitfield). Clean up the return
> > codes from mount.cifs to make them match the expected return values
> > from /bin/mount. This necessary for proper integration with autofs.
> 
> Thanks, Jeff.  I think it might be cleaner to make #define's for the
> exit codes, but I'll leave that up to you guys.
> 

Agreed...

If libmount ever gets off the ground, I expect that the header files for
it will have them. I sort of dislike having our own declarations of them,
but maybe that's a better way in the interim.

-- 
Jeff Layton <jlayton at redhat.com>


More information about the samba-technical mailing list