http://git.samba.org/?p=tprouty/samba.git; a=shortlog; h=create_file_refactor

Volker Lendecke Volker.Lendecke at SerNet.DE
Sun Nov 30 18:46:21 GMT 2008


On Sun, Nov 30, 2008 at 10:04:59AM -0800, Tim Prouty wrote:
> I introduced the new is_dos_path argument to the SMB_VFS_CREATE_FILE  
> interface to avoid calling unix_convert twice on a path.  All callers  
> that were previously calling open_file_ntcreate directly, pass in  
> false, which informs create_file that it should skip the  
> unix_convert.  These callers will go through more checks than they  
> previously had, but most of the checks are no-ops due to the arguments  
> passed into SMB_VFS_CREATE_FILE.

Eventually we will probably end up with a "struct pathname",
much like Samba 4 handles paths. But for now, as much as I
hate boolean flags passed down, I think this is okay.

Jeremy, from my point of view this can go in. What do you
think?

Volker
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20081130/b8a67035/attachment.bin


More information about the samba-technical mailing list