http://git.samba.org/?p=tprouty/samba.git; a=shortlog; h=create_file_refactor

[Tim Prouty]

On Nov 29, 2008, at 1:32 AM, Volker Lendecke wrote:

> In general that looks very good, although I am a bit worried
> about the implications of changing the direct callers of
> open_file_ntcreate to create_file. open_file_ntcreate
> assumes quite a bit of preprocessing like a unix path etc,
> create_file does this again. It does survive make test for
> me as well, but I'm not sure those code paths are really
> covered by make test. For example, copy_internals, which
> test does cover that?
>
> Volker

I introduced the new is_dos_path argument to the SMB_VFS_CREATE_FILE  
interface to avoid calling unix_convert twice on a path.  All callers  
that were previously calling open_file_ntcreate directly, pass in  
false, which informs create_file that it should skip the  
unix_convert.  These callers will go through more checks than they  
previously had, but most of the checks are no-ops due to the arguments  
passed into SMB_VFS_CREATE_FILE.

Also, copy_internals is exercised by RAW-RENAME:  
test_nttransrename().  I understand "make test" isn't comprehensive,  
but it's the most comprehensive test suite that I know of :).

-Tim